Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sketcher] Only move one piece of B-spline when dragging #7110

Conversation

AjinkyaDahale
Copy link
Contributor

@AjinkyaDahale AjinkyaDahale commented Jun 28, 2022

This is useful since splines can get very long.

fc-sketcher-move-piece

Not yet complete. Next steps include:

  1. This currently doesn't work well with periodic B-splines. This is potentially fixed now. Could use more testing.
  2. There should be options for both moving the entire B-spline or just one piece.

@github-actions github-actions bot added the WB Sketcher Related to the Sketcher Workbench label Jun 28, 2022
@AjinkyaDahale AjinkyaDahale force-pushed the sketcher-move-bspline-by-piece branch from 846438c to de98eda Compare June 29, 2022 05:08
@AjinkyaDahale AjinkyaDahale marked this pull request as ready for review June 29, 2022 08:26
@AjinkyaDahale
Copy link
Contributor Author

Marked as ready for review since it is working for periodic b-splines now.

@AjinkyaDahale AjinkyaDahale force-pushed the sketcher-move-bspline-by-piece branch 3 times, most recently from 2902b58 to 5d433b0 Compare July 1, 2022 05:03
@abdullahtahiriyo
Copy link
Contributor

It looks really nice!!

I hope to have some time over the weekend to review the code.

@AjinkyaDahale AjinkyaDahale force-pushed the sketcher-move-bspline-by-piece branch from 5d433b0 to 78aa997 Compare July 2, 2022 05:16
@abdullahtahiriyo abdullahtahiriyo merged commit a88f69a into FreeCAD:master Jul 2, 2022
@abdullahtahiriyo
Copy link
Contributor

Very nice. Thank you. Merged.

@AjinkyaDahale
Copy link
Contributor Author

Very nice. Thank you. Merged.

Glad you liked it. Please take a look at the forum post on this, because I suspect there would be people who would want it the old way.

@abdullahtahiriyo
Copy link
Contributor

@AjinkyaDahale

I am not sure if this renders impossible block dragging (by selection the poles). But, we could think of having both, maybe with a modifier key.

Honestly, the functionality was so nice and useful that it is a clear improvement. If there is something we left behind, then we ask users for ideas on how to best get it back.

@AjinkyaDahale
Copy link
Contributor Author

I am not sure if this renders impossible block dragging (by selection the poles).

What is "block dragging"? I tried to select multiple elements and drag them together, but that didn't do anything.

@AjinkyaDahale AjinkyaDahale deleted the sketcher-move-bspline-by-piece branch July 4, 2022 10:28
@abdullahtahiriyo
Copy link
Contributor

What is "block dragging"? I tried to select multiple elements and drag them together, but that didn't do anything.

You are right. It is not possible anymore.

We should probably have a way to drag as before ("as a block"). You may want to open a discussion on this topic in the forum. Let's see which ideas pop up.

@AjinkyaDahale
Copy link
Contributor Author

What is "block dragging"? I tried to select multiple elements and drag them together, but that didn't do anything.

You are right. It is not possible anymore.

So was this possible before? Looking at the code, it doesn't look as straightforward to make multi-item drag possible. I may be wrong here.

We should probably have a way to drag as before ("as a block"). You may want to open a discussion on this topic in the forum. Let's see which ideas pop up.

I had mentioned it in the forum post, but it appears it didn't have much traction. Probably something specific for multi-drag would help.

@AjinkyaDahale
Copy link
Contributor Author

@abdullahtahiriyo

You may want to open a discussion on this topic in the forum. Let's see which ideas pop up.

See https://forum.freecadweb.org/viewtopic.php?f=8&t=70046.

@AjinkyaDahale
Copy link
Contributor Author

Just noticed with this change I cannot move a spline with a single piece. I need to investigate this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Sketcher Related to the Sketcher Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants