New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sketcher] Only move one piece of B-spline when dragging #7110
[Sketcher] Only move one piece of B-spline when dragging #7110
Conversation
846438c
to
de98eda
Compare
Marked as ready for review since it is working for periodic b-splines now. |
2902b58
to
5d433b0
Compare
It looks really nice!! I hope to have some time over the weekend to review the code. |
5d433b0
to
78aa997
Compare
Very nice. Thank you. Merged. |
Glad you liked it. Please take a look at the forum post on this, because I suspect there would be people who would want it the old way. |
I am not sure if this renders impossible block dragging (by selection the poles). But, we could think of having both, maybe with a modifier key. Honestly, the functionality was so nice and useful that it is a clear improvement. If there is something we left behind, then we ask users for ideas on how to best get it back. |
What is "block dragging"? I tried to select multiple elements and drag them together, but that didn't do anything. |
You are right. It is not possible anymore. We should probably have a way to drag as before ("as a block"). You may want to open a discussion on this topic in the forum. Let's see which ideas pop up. |
So was this possible before? Looking at the code, it doesn't look as straightforward to make multi-item drag possible. I may be wrong here.
I had mentioned it in the forum post, but it appears it didn't have much traction. Probably something specific for multi-drag would help. |
|
Just noticed with this change I cannot move a spline with a single piece. I need to investigate this further. |
This is useful since splines can get very long.
Not yet complete. Next steps include:
This currently doesn't work well with periodic B-splines.This is potentially fixed now. Could use more testing.