Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PathOpGui.py Turning Addon edit. #7269

Closed
wants to merge 3 commits into from

Conversation

WarrenKCash
Copy link

@WarrenKCash WarrenKCash commented Jul 28, 2022

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the issue ID number from our Issues database in case a particular commit solves or is related to an existing issue. Ex: Draft: fix typos - fixes #4805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


@github-actions github-actions bot added the WB CAM Related to the CAM/Path Workbench label Jul 28, 2022
@WarrenKCash
Copy link
Author

WarrenKCash commented Jul 29, 2022

The link to related FreeCAD forum post https://forum.freecadweb.org/viewtopic.php?style=5&f=15&t=30563&start=150

@WarrenKCash WarrenKCash reopened this Jul 29, 2022
@WarrenKCash WarrenKCash marked this pull request as ready for review July 29, 2022 00:57
@luzpaz luzpaz requested a review from sliptonic July 29, 2022 13:34
@luzpaz
Copy link
Contributor

luzpaz commented Jul 29, 2022

@WarrenKCash thanks for braving git

@berndhahnebach
Copy link
Contributor

pipeline status for feature branch PR_7269. Pipeline 600469887 was triggered at e4ea88a. All CI branches and pipelines.

@@ -1375,7 +1375,7 @@ def Create(res):
that is created in each operations Gui implementation."""
FreeCAD.ActiveDocument.openTransaction("Create %s" % res.name)
try:
obj = res.objFactory(res.name, obj=None, parentJob=res.job)
obj = res.objFactory(res.name, obj=None)#, parentJob=res.job)
Copy link
Contributor

@mlampert mlampert Aug 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being late to the party. This is not the best way of avoiding the issue and this change breaks creation of ops when there are multiple jobs in a single file.

The much better, and correct way of dealing with the issue is add the parentJob named parameter to all the Create(..) functions of the Ops in FreeCAD_Turning_Addon .

FYI: the additional parameters for Create(..) came in ~ a year ago with PR #4797

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sliptonic
Copy link
Member

Per @mlampert's comment, this should be fixed in liblathe. I will close this PR in a few days unless I hear back.

@WarrenKCash
Copy link
Author

Hello everyone thank for the help. As @mlampert's suggested I have added the parent job to the end of each turning op's in lib lathe and it seems to function as intended with the original pathOpGui.py file in FreeCAD. I will post the files on the FreeCAD Path LibLathe forum discussion for others to test.
@sliptonic please close this request.

@sliptonic
Copy link
Member

closing per discussion

@sliptonic sliptonic closed this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB CAM Related to the CAM/Path Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants