New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PathOpGui.py Turning Addon edit. #7269
Conversation
Update PathOpGui.py
The link to related FreeCAD forum post https://forum.freecadweb.org/viewtopic.php?style=5&f=15&t=30563&start=150 |
@WarrenKCash thanks for braving |
@@ -1375,7 +1375,7 @@ def Create(res): | |||
that is created in each operations Gui implementation.""" | |||
FreeCAD.ActiveDocument.openTransaction("Create %s" % res.name) | |||
try: | |||
obj = res.objFactory(res.name, obj=None, parentJob=res.job) | |||
obj = res.objFactory(res.name, obj=None)#, parentJob=res.job) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being late to the party. This is not the best way of avoiding the issue and this change breaks creation of ops when there are multiple jobs in a single file.
The much better, and correct way of dealing with the issue is add the parentJob
named parameter to all the Create(..)
functions of the Ops in FreeCAD_Turning_Addon .
FYI: the additional parameters for Create(..)
came in ~ a year ago with PR #4797
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WarrenKCash ping
Per @mlampert's comment, this should be fixed in liblathe. I will close this PR in a few days unless I hear back. |
Hello everyone thank for the help. As @mlampert's suggested I have added the parent job to the end of each turning op's in lib lathe and it seems to function as intended with the original pathOpGui.py file in FreeCAD. I will post the files on the FreeCAD Path LibLathe forum discussion for others to test. |
closing per discussion |
Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!
App
,Base
,Gui
or one of theMod
subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next onesgit pull --rebase upstream master
./bin/FreeCAD --run-test 0
Fixes typo in Draft Move command text
Draft: Fixed typos
issue #<id>
orfixes #<id>
where<id>
is the issue ID number from our Issues database in case a particular commit solves or is related to an existing issue. Ex:Draft: fix typos - fixes #4805
And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.