Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATH: Bugfix/vcarve c++ exception #7278

Merged
merged 6 commits into from Aug 4, 2022

Conversation

mlampert
Copy link
Contributor

This fixes the behaviour noted in https://forum.freecadweb.org/viewtopic.php?f=15&t=70208.
boost::polygon::voronoi generates some edges that don't make a lot of sense to process - I called them "borderline", for lack of a better name.

Also, "Voronoi" is now a module underneath "Path" and the object names are simplified accordingly ("Path.VoronoiEdge" -> "Path.Voronoi.Edge", ....)

@github-actions github-actions bot added the WB CAM Related to the CAM/Path Workbench label Jul 30, 2022
@berndhahnebach
Copy link
Contributor

pipeline status for feature branch PR_7278. Pipeline 600698013 was triggered at 24a36f1. All CI branches and pipelines.

@mlampert mlampert force-pushed the bugfix/vcarve-c++-exception branch from 24a36f1 to 234ecad Compare July 30, 2022 15:35
@berndhahnebach
Copy link
Contributor

pipeline status for feature branch PR_7278. Pipeline 600909127 was triggered at 234ecad. All CI branches and pipelines.

@mlampert mlampert force-pushed the bugfix/vcarve-c++-exception branch from 234ecad to 3408d7c Compare August 2, 2022 20:32
@berndhahnebach
Copy link
Contributor

pipeline status for feature branch PR_7278. Pipeline 603226260 was triggered at 3408d7c. All CI branches and pipelines.

@berndhahnebach
Copy link
Contributor

pipeline status for feature branch PR_7278. Pipeline 603400056 was triggered at 79a9b29. All CI branches and pipelines.

@sliptonic sliptonic merged commit f7a0586 into FreeCAD:master Aug 4, 2022
@donovaly
Copy link
Member

donovaly commented Aug 5, 2022

Is this something to be backported to FC 0.20.1?

@sliptonic
Copy link
Member

Yes

donovaly pushed a commit that referenced this pull request Aug 6, 2022
@donovaly
Copy link
Member

donovaly commented Aug 6, 2022

Backported

@mlampert mlampert deleted the bugfix/vcarve-c++-exception branch September 30, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB CAM Related to the CAM/Path Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants