Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI,MOD] Replace edit-cut.svg #7353

Merged
merged 1 commit into from Aug 11, 2022

Conversation

coldtobi
Copy link

@coldtobi coldtobi commented Aug 11, 2022

Replace 2 instances of edit-cut.svg with the version from the tango icon
library to reslove license issue. Closes #7347.

Tango Icon Library used: http://tango.freedesktop.org/releases/tango-icon-theme-0.8.90.tar.gz
Location within the tarball:
./tango-icon-theme-0.8.90/scalable/actions/edit-cut.svg

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the issue ID number from our Issues database in case a particular commit solves or is related to an existing issue. Ex: Draft: fix typos - fixes #4805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


@github-actions github-actions bot added Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD WB TechDraw Related to the TechDraw Workbench labels Aug 11, 2022
Replace 2 instances of edit-cut.svg with the version from the tango icon
library to reslove license issue. Closes FreeCAD#7347.

Tango Icon Library used: http://tango.freedesktop.org/releases/tango-icon-theme-0.8.90.tar.gz
Location within the tarball:
./tango-icon-theme-0.8.90/scalable/actions/edit-cut.svg
@coldtobi coldtobi changed the title Replace edit-cut.svg [GUI,MOD] Replace edit-cut.svg Aug 11, 2022
@berndhahnebach
Copy link
Contributor

pipeline status for feature branch PR_7353. Pipeline 610264591 was triggered at c742451. All CI branches and pipelines.

@berndhahnebach
Copy link
Contributor

pipeline status for feature branch PR_7353. Pipeline 610267964 was triggered at f1f1156. All CI branches and pipelines.

@chennes
Copy link
Member

chennes commented Aug 11, 2022

Thanks for the PR, and for tracking down the relicensed versions of these icons. It looks like besides the license all of the other changes are just internal Inkscape stuff, and visually they are identical. I'm going to go ahead and merge.

@chennes chennes merged commit 9311e29 into FreeCAD:master Aug 11, 2022
@coldtobi coldtobi deleted the replace-cut-edit-icon branch August 11, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD WB TechDraw Related to the TechDraw Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Icon "edit-cut.svg" is licensed CC-BY-SA-NC-2.0, which is a problem for Debian
3 participants