[PartDesign] [Hole] Fixed hole error caused by special characters in windows username #7383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwmayer
reviewed
Aug 21, 2022
| @@ -2295,7 +2297,8 @@ void Hole::readCutDefinitions() | |||
| for (const auto& f : files) { | |||
| if (f.extension() == "json") { | |||
| try { | |||
| std::ifstream input(f.filePath()); | |||
| Base::FileInfo fi(f.filePath()); | |||
There was a problem hiding this comment.
f already is a FileInfo object. So, no need to create a tmp. object.
There was a problem hiding this comment.
Thanks, 74f7154 is this correct now?
|
Merged. |
luzpaz
changed the title
|
Congrats @howie-j on your 1st PR and successful merge. As always, thanks again wmayer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not a c++ developer, please check/fix before merging..
The PartDesign::Hole tool fails to read all "Mod/PartDesign/Resources/Hole/xxxxx.json" files if your windows username contains special characters.
Forum thread: Hole tool fails with special characters in the username
@wwmayer fixed a similar issue in techdraw with this commit,
so i attempted to fix this issue for the hole tool with the info from this post.
Compiles and works on linux, but not tested on windows.
Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!
App,Base,Guior one of theModsubfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next onesgit pull --rebase upstream master./bin/FreeCAD --run-test 0Fixes typo in Draft Move command textDraft: Fixed typosissue #<id>orfixes #<id>where<id>is the issue ID number from our Issues database in case a particular commit solves or is related to an existing issue. Ex:Draft: fix typos - fixes #4805And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.