[For testing] Sketcher: optionally merge 'coincident' within 'point-on-object' constraint

[0penBrain]

The merge is activated with User parameter:BaseApp/Preferences/Mod/Sketcher/General/MergePointOnObjectWithCoincident boolean switch

The PR is essentially done to have a test between 2 flavors (merged or not) and decide what is to be kept.

The "feature" is only the last commit. 3 first commits are independent fixes and improvements.

[berndhahnebach]

for feature branch PR_7478. Pipeline 637873179 was triggered at c674aaa. All CI branches and pipelines.

[donovaly]

Many thanks.
However, can you please split the PR into at least two. The new feature should become its own PR so that one can test it better and once it is merged we can reference it in the release notes as reference.

To be precise, what are the issues fixed by the first commits?
What is the feature of the 4th commit?

[0penBrain]

@donovaly This PR was intended mainly for testing. Was not clear, I clarified in title and set to draft.
I will comment the 3 first commits on a new PR with only these 3 ones. To be clear, I'll let this PR as is, then latter rebase if/when 3 first commits are merged into master so this one will only be the last commit.

The last commit allows (with parameter switch in the description) to merge Sketcher 'coincident constraint' into 'point-on-object' constraint. It means that 'coincident' is no more present in the default menu/toolbar, and you can apply a coincident constraint by selecting 2 or more vertices and clicking 'point-on-object'.

[luzpaz]

@0penBrain do you want an experimental snap build for testers to test this PR ?

[0penBrain]

@0penBrain do you want an experimental snap build for testers to test this PR ?

For myself I have a build. :) Maybe better ask in the forum discussion ;)

[luzpaz]

Sure! Link to forum discussion?

[0penBrain]

Sure! Link to forum discussion?

Arf. Silly me. Was sure it was on the description : https://forum.freecadweb.org/viewtopic.php?f=8&t=71793

[adrianinsaval]

I myself also had a build but would appreciate if there is a snap and more testers, hopefully some of the detractors can give it a chance too.

[luzpaz]

Snap build triggered at FreeCAD/FreeCAD-snap#62 (x-posting to thread as well)

[abdullahtahiriyo]

@0penBrain

Are you pursuing this? Do you want me to take a look?

[0penBrain]

@abdullahtahiriyo This was for community testing and feedback. AFAIK there's no agreement from community to move forward to this. I plan nothing for this ATM. ;)

[abdullahtahiriyo]

OK. Thanks.

[adrianinsaval]

Now that coincidence can work by selecting circle edges I think this is no longer viable, that is a very useful functionality so it's not worth loosing it for this IMO (and I was a big supporter of this).

[abdullahtahiriyo]

If I understood it correctly, could then we perhaps close the PR?

[0penBrain]

Yes I close. No need to let it queued. We can reopen another (clean) PR in the future if we have a need for this. ;)