Gui: Use auto and range-based for #7481

berniev · 2022-09-13T05:29:05Z

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!

Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
Your branch is rebased on latest master git pull --rebase upstream master
All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
All commit messages are well-written ex: Fixes typo in Draft Move command text
Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
Commit messages include issue #<id> or fixes #<id> where <id> is the issue ID number from our Issues database in case a particular commit solves or is related to an existing issue. Ex: Draft: fix typos - fixes #4805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 1.0 Changelog Forum Thread.

berndhahnebach · 2022-09-13T05:36:14Z

for feature branch PR_7481. Pipeline 638334212 was triggered at 3f22bdb. All CI branches and pipelines.

src/Gui/DAGView/DAGView.cpp

src/Gui/DlgExpressionInput.cpp

src/Gui/DlgMaterialPropertiesImp.cpp

src/Gui/DlgToolbarsImp.cpp

src/Gui/Document.cpp

src/Gui/InputField.cpp

src/Gui/InventorNavigationStyle.cpp

src/Gui/NaviCube.cpp

src/Gui/Placement.cpp

src/Gui/SpinBox.cpp

src/Gui/Splashscreen.cpp

src/Gui/TaskView/TaskAppearance.cpp

src/Gui/View3DInventorExamples.cpp

src/Gui/ViewProviderDocumentObject.cpp

src/Gui/ViewProviderDragger.cpp

src/Gui/propertyeditor/PropertyItem.cpp

chennes

Thanks for the PR -- I've left a few comments where I had questions, or there were issues (all very minor).

berndhahnebach · 2022-09-14T05:04:11Z

for feature branch PR_7481. Pipeline 639491067 was triggered at 27ea890. All CI branches and pipelines.

berndhahnebach · 2022-09-14T06:13:38Z

for feature branch PR_7481. Pipeline 639528157 was triggered at 2f24c1b. All CI branches and pipelines.

* On lines where the variable type is obvious from inspection, avoid repeating the type using auto. * When possible use a ranged for loop instead of begin() and end() iterators

auto

3f22bdb

github-actions bot added the Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label Sep 13, 2022