Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui: Allow None parameter again in drag and drop methods in Python ViewProviderPy class #7507

Merged

Conversation

marioalexis84
Copy link
Member

@donovaly separate pull request acording to https://forum.freecad.org/viewtopic.php?p=625495&sid=fbd133d17eb6673b7df62527a4054cfb#p625495
Pull request related: #7236

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the issue ID number from our Issues database in case a particular commit solves or is related to an existing issue. Ex: Draft: fix typos - fixes #4805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 1.0 Changelog Forum Thread.


@github-actions github-actions bot added Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD WB Part Related to the Part Workbench labels Sep 17, 2022
@berndhahnebach
Copy link
Contributor

pipeline status for feature branch PR_7507. Pipeline 643111783 was triggered at a53a256. All CI branches and pipelines.

@donovaly
Copy link
Member

Thanks! I will merge after I could merge #7236

@donovaly
Copy link
Member

Wait, this PR is for master. In https://forum.freecad.org/viewtopic.php?p=625495&sid=61fd6b73f879d0636baa47506e4a0cf6#p625495 I requested a PR for the 0-20 branch.

To avoid confusions, can you please make ONE PR for master fixing the bug. If necessary please make a second PR for further improvements. First when the changes are merged into master, we can take care for the backporting.

@donovaly donovaly self-assigned this Sep 19, 2022
@marioalexis84 marioalexis84 changed the base branch from master to releases/FreeCAD-0-20 September 20, 2022 14:41
@marioalexis84 marioalexis84 changed the base branch from releases/FreeCAD-0-20 to master September 20, 2022 14:41
@marioalexis84 marioalexis84 changed the base branch from master to releases/FreeCAD-0-20 September 20, 2022 14:42
@marioalexis84
Copy link
Member Author

marioalexis84 commented Sep 20, 2022

@donovaly pull request changed to FreeCAD-0-20.
The bug in master is fixed in #7236

@berndhahnebach
Copy link
Contributor

pipeline status for feature branch PR_7507. Pipeline 645562980 was triggered at 600a644. All CI branches and pipelines.

@donovaly donovaly merged commit 8458569 into FreeCAD:releases/FreeCAD-0-20 Sep 24, 2022
@marioalexis84 marioalexis84 deleted the gui-viewprovider_py branch March 24, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD WB Part Related to the Part Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants