Sketcher: Coincidence constraint: fix error introduced by concentric

[PaddleStroke]

Fix bug mentioned by @0penBrain introduced in : #7703 (comment)

Thank you for creating a pull request to contribute to FreeCAD! Place an "X" in between the brackets below to "check off" to confirm that you have satisfied the requirement, or ask for help in the FreeCAD forum if there is something you don't understand.

• Your Pull Request meets the requirements outlined in section 5 of CONTRIBUTING.md for a Valid PR

Please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 1.0 Changelog Forum Thread.

---

[freecadci]

for feature branch PR_7794. Pipeline 693715672 was triggered at 665939a. All CI branches and pipelines.

[0penBrain]

Not tested, but I think something like this is more clear:

    bool allConicsEdges = true; //If user selects only conics (circle, ellipse, arc, arcOfEllipse) then we make concentric constraint.
    bool atLeastOneEdge = false;
    for (std::vector<std::string>::const_iterator it = SubNames.begin(); it != SubNames.end(); ++it) {
        int GeoId;
        Sketcher::PointPos PosId;
        getIdsFromName(*it, Obj, GeoId, PosId);
        if (isEdge(GeoId,PosId)) {
            atLeastOneEdge = true;
            if (!isGeoConcentricCompatible(Obj->getGeometry(GeoId))) {
                allConicsEdges = false;
            }
        }
        else {
            allConicsEdges = false; //at least one point is selected, so concentric can't be applied.
        }
        if (atLeastOneEdge && !allConicsEdges) {
            QMessageBox::warning(Gui::getMainWindow(), QObject::tr("Wrong selection"),
                QObject::tr("Select two or more vertices from the sketch for a coincident constraint, or two or more circles, ellipses, arcs or arcs of ellipse for a concentric constraint."));
            return;
        }
    }

//    if (atLeastOneEdge && !allConicsEdges) {
//        QMessageBox::warning(Gui::getMainWindow(), QObject::tr("Wrong selection"),
//            QObject::tr("Select two or more vertices from the sketch for a coincident constraint, or two or more circles, ellipses, arcs or arcs of ellipse for a concentric constraint."));
//        return;
//    }

Commented block can be deleted of course. :)

[freecadci]

for feature branch PR_7794. Pipeline 693756713 was triggered at 4172ba2. All CI branches and pipelines.

[PaddleStroke]

You got merging rights @0penBrain ? Good thing.

[0penBrain]

You got merging rights @0penBrain ? Good thing.

Yep. Against my own will. 🤣 Don't expect too much from that though. ;)

[PaddleStroke]

I don't expect you to be lenient 😄
But at least now you can merge things after reviewing when you deem they can be merged. Rather than having to have a second reviewer reviewing again.