New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TD]ComplexSection Fixes #7972
Merged
Merged
[TD]ComplexSection Fixes #7972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i can test the pr tomorrow. |
WandererFan
force-pushed
the
fixSlowCS
branch
from
December 10, 2022 22:04
c5e3c54
to
de96546
Compare
- was returning inflated counts of owning page
- fix jumping direction field in dialogs - apply default rotation to simple sections - fix rounding error in vector widget - remove "enter" button on CompassWidget - add lost focus trap in event filter. [TD]prevent recompute on cancel without change
- correct ComplexSection rotation - fix fail to load CS for some profiles and directions
WandererFan
force-pushed
the
fixSlowCS
branch
from
December 17, 2022 13:29
1b707d5
to
d6141ee
Compare
WandererFan
force-pushed
the
fixSlowCS
branch
from
December 17, 2022 18:44
d6141ee
to
f4cc362
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses items raised in user testing of ComplexSections. https://www.forum.freecadweb.org/viewtopic.php?p=645399#p645399
Thank you for creating a pull request to contribute to FreeCAD! Place an "X" in between the brackets below to "check off" to confirm that you have satisfied the requirement, or ask for help in the FreeCAD forum if there is something you don't understand.
Please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 1.0 Changelog Forum Thread.