Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TD]ComplexSection Fixes #7972

Merged
merged 4 commits into from Dec 18, 2022
Merged

[TD]ComplexSection Fixes #7972

merged 4 commits into from Dec 18, 2022

Conversation

WandererFan
Copy link
Contributor

addresses items raised in user testing of ComplexSections. https://www.forum.freecadweb.org/viewtopic.php?p=645399#p645399

Thank you for creating a pull request to contribute to FreeCAD! Place an "X" in between the brackets below to "check off" to confirm that you have satisfied the requirement, or ask for help in the FreeCAD forum if there is something you don't understand.

  • Your Pull Request meets the requirements outlined in section 5 of CONTRIBUTING.md for a Valid PR

Please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 1.0 Changelog Forum Thread.


@github-actions github-actions bot added the WB TechDraw Related to the TechDraw Workbench label Dec 7, 2022
@freecadci
Copy link

pipeline status for feature branch PR_7972. Pipeline 716001118 was triggered at a0fe7ad. All CI branches and pipelines.

@ghost
Copy link

ghost commented Dec 7, 2022

i can test the pr tomorrow.

@freecadci
Copy link

pipeline status for feature branch PR_7972. Pipeline 717133641 was triggered at fed8363. All CI branches and pipelines.

@freecadci
Copy link

pipeline status for feature branch PR_7972. Pipeline 717742488 was triggered at 7e951e6. All CI branches and pipelines.

@freecadci
Copy link

pipeline status for feature branch PR_7972. Pipeline 718292476 was triggered at 8b511b9. All CI branches and pipelines.

@freecadci
Copy link

pipeline status for feature branch PR_7972. Pipeline 718576295 was triggered at c5e3c54. All CI branches and pipelines.

@freecadci
Copy link

pipeline status for feature branch PR_7972. Pipeline 718949165 was triggered at de96546. All CI branches and pipelines.

@freecadci
Copy link

pipeline status for feature branch PR_7972. Pipeline 719205826 was triggered at 1b707d5. All CI branches and pipelines.

- was returning inflated counts of owning page
- fix jumping direction field in dialogs

- apply default rotation to simple sections

- fix rounding error in vector widget

- remove "enter" button on CompassWidget

- add lost focus trap in event filter.

[TD]prevent recompute on cancel without change
- correct ComplexSection rotation

- fix fail to load CS for some profiles and directions
@freecadci
Copy link

pipeline status for feature branch PR_7972. Pipeline 725915503 was triggered at f4cc362. All CI branches and pipelines.

@WandererFan WandererFan merged commit 47ef350 into FreeCAD:master Dec 18, 2022
@WandererFan WandererFan deleted the fixSlowCS branch December 18, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB TechDraw Related to the TechDraw Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants