Group fixes #803
Closed
Group fixes #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, @ickby does this PR address any open mantis tickets ? |
|
@luzpaz I don't know. Most of this code is already a bit older, I did some cherry picking and updating now to submit the PR. There have been a few forum topics about issues that are going to be solved with this code, but tracker issues I don't know anymore. I can have a look through the tracker later, need to tackle that build failure anyway... |
|
@luzpaz thanks for looking those up. I think those three are fixed: https://freecadweb.org/tracker/view.php?id=2142 |
Property group "User parameter:BaseApp/Preferences/DependencyGraph" has two booleans to enable subgraphing and unflatten (by default on): "Unflatten", "GeoFeatureSubgraphs"
The user expects to undo the drag and drop action with a single click (as it happens with a single drag&drop action). Hence the command must be handled by the tree, not the viewproviders.
The DAG test is not needed anymore as the relevant functions are non-DAG save now, and the other check will be moved to the recompute as it is not efficient or save to do it in the links itself.
|
Rebased to current master |
|
Merged. |
|
Go Werner! 👍 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:
git pull --rebase upstream master./bin/FreeCAD --run-test 0issue #<id>orfixes #<id>where<id>is the associated MantisBT issue id if one existsAnd please remember to update the Wiki with the features added or changed once this PR once it is merged.
This pull request adds many useful things for handling Groups and GeoFeatureGroups. It improves object adding, Drag'n'Drop, undo/redo, DependencyGraph visualisation, Placement calculation and dependency tracking.
The changes do not add support for forbidding cross coordinate system links or new link properties to handle that as initially discussed. This will be part of another pull request, as it requires more research.