Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] increase number spinboxes max in array task panels to 1 million #8628

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Feb 24, 2023

The default max for spinboxes is 99. This PR increases it to 1 million for the number spin boxes of the array task panels.

  • Your Pull Request meets the requirements outlined in section 5 of CONTRIBUTING.md for a Valid PR

The default max for spinboxes is 99. This PR increases it to 1 million for the number spin boxes of the array task panels.
@github-actions github-actions bot added the WB Draft Related to the Draft Workbench label Feb 24, 2023
@freecadci
Copy link

pipeline status for feature branch PR_8628. Pipeline 788189054 was triggered at 5e4216b. All CI branches and pipelines.

@Roy-043 Roy-043 merged commit 63cb23d into FreeCAD:master Feb 24, 2023
@Roy-043 Roy-043 deleted the Draft-increase-number-spinboxes-max-in-array-task-panels-to-1-million branch February 24, 2023 15:16
@0penBrain
Copy link
Contributor

Why not just remove the property?

@Roy-043
Copy link
Contributor Author

Roy-043 commented Feb 24, 2023

Sorry, but what property do you mean?

@0penBrain
Copy link
Contributor

Sorry, but what property do you mean?

The 'maximum' property. If you delete it from the UI files, it will just be initialized with the default value. ;)

@Roy-043
Copy link
Contributor Author

Roy-043 commented Feb 24, 2023

The default max value, without the maximum property, is 99. Users want to be able to enter higher values.

See: https://doc.qt.io/qt-6/qspinbox.html#maximum-prop

@FreeCAD FreeCAD deleted a comment from MarcusMWilliams Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Draft Related to the Draft Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants