App: Fix missing python addProperty and removeProperty of Document object #8920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Core
0penBrain
reviewed
Mar 18, 2023
| getDocumentPtr()->addDynamicProperty(sType,sName,sGroup,sDocStr.c_str(),attr, | ||
| Base::asBoolean(ro), Base::asBoolean(hd)); | ||
|
|
||
| return Py::new_reference_to(this); |
There was a problem hiding this comment.
@wwmayer Is it sensible to return a reference to the object (Document in this case) rather than to the created property ?
I saw it's same in DocumentObjectPy implementation, so it's a general question. :)
There was a problem hiding this comment.
We don't have Python wrappers for Property classes. When trying to access a property of a document(object) you get directly its value. So, yes, it's sensible to return a reference of itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python Document class didn't have addProperty nor removeProperty but such behavior was available throw GUI.
Forum discussion (french): https://forum.freecad.org/viewtopic.php?t=76855