Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part: make PropertyGeometryList more permissive #9081

Merged
merged 1 commit into from Mar 27, 2023

Conversation

wwmayer
Copy link
Contributor

@wwmayer wwmayer commented Mar 27, 2023

Since not all Geometry sub-classes fully implement Save() / Restore() raising an exception instead may invalidate a project. To avoid this PropertyGeometryList now explicitly handles NotImplementedError exceptions.

See also: https://forum.freecad.org/viewtopic.php?t=77148

Thank you for creating a pull request to contribute to FreeCAD! Place an "X" in between the brackets below to "check off" to confirm that you have satisfied the requirement, or ask for help in the FreeCAD forum if there is something you don't understand.

  • Your Pull Request meets the requirements outlined in section 5 of CONTRIBUTING.md for a Valid PR

Please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 1.0 Changelog Forum Thread.


Since not all Geometry sub-classes fully implement Save() / Restore() raising an exception instead may invalidate a project. To avoid this
PropertyGeometryList now explicitly handles NotImplementedError exceptions.

See also: https://forum.freecad.org/viewtopic.php?t=77148
@github-actions github-actions bot added the WB Part Related to the Part Workbench label Mar 27, 2023
@freecadci
Copy link

pipeline status for feature branch PR_9081. Pipeline 819110285 was triggered at 7c296aa. All CI branches and pipelines.

@wwmayer wwmayer merged commit ca935a4 into FreeCAD:master Mar 27, 2023
6 of 7 checks passed
@wwmayer wwmayer deleted the PropertyGeometryList__exception branch March 27, 2023 14:09
@donovaly
Copy link
Member

Should/could that be backported?

@wwmayer
Copy link
Contributor Author

wwmayer commented Mar 27, 2023

Yes

@donovaly
Copy link
Member

Thanks, backported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Part Related to the Part Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants