[PATH] Update getDrillableTargets() to evaluate all faces 1..<n>

[jimzim111]

This fixes one cause of valid holes not getting included in Drill/Helix Ops due to a list iteraton off-by-one counter. Detailed explanation at https://forum.freecad.org/viewtopic.php?style=5&t=77055 (the first cause discussed on that post, disregard the 2nd as I'm still investigating/working on that one)

Thank you for creating a pull request to contribute to FreeCAD! Place an "X" in between the brackets below to "check off" to confirm that you have satisfied the requirement, or ask for help in the FreeCAD forum if there is something you don't understand.

• Your Pull Request meets the requirements outlined in section 5 of CONTRIBUTING.md for a Valid PR

Please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 1.0 Changelog Forum Thread.

---

[freecadci]

for feature branch PR_9146. Pipeline 826746112 was triggered at 8b03616. All CI branches and pipelines.

[sliptonic]

I'm merging this because it passes tests and appears to resolve a real problem. However, there is no github issue, only a forum topic.
What concerns me is that the existing unit tests didn't detect the original problem and we've added no new unit tests to the suite.
Why didn't the problem surface before? Was it that the current unit tests only have a single base object in the job? Was it that the Face0 or FaceN didn't have a hole?

[jimzim111]

I think the bug could hit a single base object or any/all of multiple bases. It's just random luck of the draw- if a valid hole face happens to be the highest face number of the entire object it would be missed. In order to create a test case, do you know if there's any way to influence the numbering of faces when objects are computed? Or if not, maybe I can try making an object with a valid hole and as few other faces as possible to maximize the odds that the hole gets the highest face number.

…

On Tue, Apr 4, 2023, 2:44 PM sliptonic ***@***.***> wrote: Merged #9146 <#9146> into master. — Reply to this email directly, view it on GitHub <#9146 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACPVIE4CIDND6NH2I3TR3ULW7SI3JANCNFSM6AAAAAAWPKQFAY> . You are receiving this because you authored the thread.Message ID: ***@***.***>