Sketcher: restore toolbars when changing between workbenches in edit …

[wwmayer]

…mode

This partially fixes issue #9135

Thank you for creating a pull request to contribute to FreeCAD! Place an "X" in between the brackets below to "check off" to confirm that you have satisfied the requirement, or ask for help in the FreeCAD forum if there is something you don't understand.

• Your Pull Request meets the requirements outlined in section 5 of CONTRIBUTING.md for a Valid PR

Please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 1.0 Changelog Forum Thread.

---

[chennes]

Suggested change

	// alwas controlled by the application.
	// always controlled by the application.

[chennes]

Do you have an opinion about the

'auto it' can be declared as 'auto *it' [readability-qualified-auto]

linter warning? I'm not a huge fan of the unnecessary *, I feel like C++ has enough punctuation already and to me that doesn't make the code any clearer in most cases (though I grant that there are some exceptions where it does make sense to include the *). Anyway, I'd be in favor of disabling that lint check.

[wwmayer]

linter warning? I'm not a huge fan of the unnecessary *, I feel like C++ has enough punctuation already and to me that doesn't make the code any clearer in most cases (though I grant that there are some exceptions where it does make sense to include the *). Anyway, I'd be in favor of disabling that lint check.

Absolutely. We should disable the warning.

Another warning that I see frequently is that a function could be made static but the code checker completely ignores the fact that in many cases the function overrides a virtual function and thus it's not possible to make it static.