Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path: make drilling cycles G98/G99 aware. #9153

Closed
wants to merge 7 commits into from
Closed

Path: make drilling cycles G98/G99 aware. #9153

wants to merge 7 commits into from

Conversation

J-Dunn
Copy link
Contributor

@J-Dunn J-Dunn commented Apr 1, 2023

Thank you for creating a pull request to contribute to FreeCAD! Place an "X" in between the brackets below to "check off" to confirm that you have satisfied the requirement, or ask for help in the FreeCAD forum if there is something you don't understand.

  • [x ] Your Pull Request meets the requirements outlined in section 5 of CONTRIBUTING.md for a Valid PR

Please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 1.0 Changelog Forum Thread.


This PR adds G99 retract mode awareness to drilling cycles G81/G83 , finally making it NIST conformant.
This satisfies both the need to avoid multiple retractions and air cutting on unobstructed jobs, and respects safe height between holes when required, preventing the tool-crashes produced by fudging G98 to act like G99 and silently ignoring safe height as is current implemented.

A new KeepToolDown checkbox is added to UI , per wsk8's previous suggestion.
Old paths are automatically migrated to add the new object properties, so existing FCStd files will be compatible.
3Dview also gets to be G98 compliant ( it previously ignored retract modes, so this should not be visible to existing paths ).

@github-actions github-actions bot added the WB CAM Related to the CAM/Path Workbench label Apr 1, 2023
@GeneGH
Copy link
Contributor

GeneGH commented Apr 1, 2023

I do not understand the use of "keep tool down" as a proxy for G99. The drill still needs to go up between holes. This terminology seems misleading. It is not consistent with the usage in other parts of the Path WB where the milling cutter does not rise at all.

@J-Dunn
Copy link
Contributor Author

J-Dunn commented Apr 1, 2023

Thanks. Fair point. I adopted that from wsk8's PR, maybe without due consideration. If this is used elsewhere in a difference sense, it could be changed. I'll wait for other f/b and make a new PR if it's worth it.

Should this be "Retract mode" with a drop down list of G98 and G99 ? Is that the most intelligible to the use who may not be skilled in hand written Gcode?

@freecadci
Copy link

pipeline status for feature branch PR_9153. Pipeline 826746117 was triggered at 0c43789. All CI branches and pipelines.

@J-Dunn J-Dunn closed this by deleting the head repository Apr 6, 2023
@J-Dunn
Copy link
Contributor Author

J-Dunn commented Apr 6, 2023

master update and lint tidy up submitted as #9200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB CAM Related to the CAM/Path Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants