Path: make drilling cycles G98/G99 aware. #9153
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for creating a pull request to contribute to FreeCAD! Place an "X" in between the brackets below to "check off" to confirm that you have satisfied the requirement, or ask for help in the FreeCAD forum if there is something you don't understand.
Please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 1.0 Changelog Forum Thread.
This PR adds G99 retract mode awareness to drilling cycles G81/G83 , finally making it NIST conformant.
This satisfies both the need to avoid multiple retractions and air cutting on unobstructed jobs, and respects safe height between holes when required, preventing the tool-crashes produced by fudging G98 to act like G99 and silently ignoring safe height as is current implemented.
A new KeepToolDown checkbox is added to UI , per wsk8's previous suggestion.
Old paths are automatically migrated to add the new object properties, so existing FCStd files will be compatible.
3Dview also gets to be G98 compliant ( it previously ignored retract modes, so this should not be visible to existing paths ).