Draft: Fix inaccuracy in Draft Edit command #9202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. Please remove the Draft status. IMO this PR can be merged. |
alafr
force-pushed
the
fix_draft_edit_inaccuracy
branch
from
874399d
to
c765449
Compare
|
Many thanks. Will merge this now. |
Roy-043
pushed a commit
to Roy-043/FreeCAD
that referenced
this pull request
Apr 12, 2023
|
Backported to V0.20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the issue described in the forum
coin.SoCoordinate3()used in theEditTrackerclass rounds the x,y,z values. The loss of precision is not a lot (few micrometers) but it's apparently enough to create problems with planar faces and boolean operations.This PR modifies the
setandgetfunctions ofEditTrackerso that the position is saved with precision in aApp.VectorSet as draft because I didn't test it a lot.
Thank you for creating a pull request to contribute to FreeCAD! Place an "X" in between the brackets below to "check off" to confirm that you have satisfied the requirement, or ask for help in the FreeCAD forum if there is something you don't understand.
Please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 1.0 Changelog Forum Thread.