Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Material workbench preferences from FEM workbench to its own preferences page #9210

Closed
wants to merge 17 commits into from

Conversation

davesrocketshop
Copy link
Contributor

Thank you for creating a pull request to contribute to FreeCAD! Place an "X" in between the brackets below to "check off" to confirm that you have satisfied the requirement, or ask for help in the FreeCAD forum if there is something you don't understand.

  • Your Pull Request meets the requirements outlined in section 5 of CONTRIBUTING.md for a Valid PR

Please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 1.0 Changelog Forum Thread.


@github-actions github-actions bot added the WB FEM Related to the FEM Workbench label Apr 7, 2023
@freecadci
Copy link

pipeline status for feature branch PR_9210. Pipeline 830835044 was triggered at ed6a6b9. All CI branches and pipelines.

@sliptonic
Copy link
Member

Is there an issue or forum topic where this was discussed?

@luzpaz luzpaz added the Missing: forum discussion MIssing a forum post discussion with the FC community label Apr 7, 2023
@davesrocketshop
Copy link
Contributor Author

I did see one a week or so ago where someone said they were going to do it but it was never done. I started a new thread: https://forum.freecad.org/viewtopic.php?p=673998#p673998

@freecadci
Copy link

pipeline status for feature branch PR_9210. Pipeline 832018964 was triggered at 13ab05e. All CI branches and pipelines.

@luzpaz luzpaz removed the Missing: forum discussion MIssing a forum post discussion with the FC community label Apr 10, 2023
@freecadci
Copy link

pipeline status for feature branch PR_9210. Pipeline 836934205 was triggered at d87beb9. All CI branches and pipelines.

@davesrocketshop
Copy link
Contributor Author

davesrocketshop commented May 4, 2023

Included bug fixes, usability enhancements (mostly bug fixes), and use of new preferences that allow external workbenches to add to the material search paths.

This is all outlined in the discussion thread: https://forum.freecad.org/viewtopic.php?p=673998

@freecadci
Copy link

pipeline status for feature branch PR_9210. Pipeline 903667657 was triggered at b282edd. All CI branches and pipelines.

@davesrocketshop
Copy link
Contributor Author

This pull request is now obsolete. It was intended as part of release 0.21, and quite frankly should have been in there.

This will now be addressed as part of the material overhaul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB FEM Related to the FEM Workbench
Development

Successfully merging this pull request may close these issues.

None yet

4 participants