Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Setting initial color of QColorDialog #9287

Merged
merged 1 commit into from
Apr 16, 2023
Merged

Conversation

xtemp09
Copy link
Contributor

@xtemp09 xtemp09 commented Apr 16, 2023

This commit fixes issue #7322. When setting option the initial color is discarded. It needs to be reset, like it's done in void ColorButton::showModal().

Before
before.mp4
After
after.mp4

Standard form

Thank you for creating a pull request to contribute to FreeCAD! Place an "X" in between the brackets below to "check off" to confirm that you have satisfied the requirement, or ask for help in the FreeCAD forum if there is something you don't understand.

  • Your Pull Request meets the requirements outlined in section 5 of CONTRIBUTING.md for a Valid PR

Please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 1.0 Changelog Forum Thread.

@github-actions github-actions bot added the Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label Apr 16, 2023
@freecadci
Copy link

pipeline status for feature branch PR_9287. Pipeline 838605566 was triggered at 1e16267. All CI branches and pipelines.

@chennes chennes self-assigned this Apr 16, 2023
@chennes
Copy link
Member

chennes commented Apr 16, 2023

Looks great, thanks for those videos -- that's a very helpful way to show this sort of change.

@chennes chennes merged commit 6b42818 into FreeCAD:master Apr 16, 2023
7 checks passed
@xtemp09 xtemp09 mentioned this pull request Apr 17, 2023
1 task
@xtemp09 xtemp09 deleted the gui-fix2 branch February 15, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants