Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Std_TransformManip should not be called from setEdit #9375

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Apr 24, 2023

The object then seems to be put into edit mode twice (?) and Esc will not cancel the command.

Forum post:
https://forum.freecad.org/viewtopic.php?p=677099#p677099

As a workaround doubleClicked is used. This function takes precedence over all double-click edit modes. It can be used here because the affected objects (Fillet, Point, Shape2DView and PanelCut) currently only support a single edit mode.

  • Your Pull Request meets the requirements outlined in section 5 of CONTRIBUTING.md for a Valid PR

The object then seems to be put into edit mode twice (?) and Esc will not cancel the command.
@github-actions github-actions bot added WB Arch Related to the Arch Workbench WB Draft Related to the Draft Workbench labels Apr 24, 2023
@freecadci
Copy link

pipeline status for feature branch PR_9375. Pipeline 846569073 was triggered at bd33946. All CI branches and pipelines.

@Roy-043 Roy-043 merged commit bd3f71b into FreeCAD:master May 7, 2023
8 checks passed
@Roy-043 Roy-043 deleted the Draft-Std_TransformManip-should-not-be-called-from-setEdit branch May 7, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Arch Related to the Arch Workbench WB Draft Related to the Draft Workbench
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants