Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest Machining for Path and Path3D Operations #9782

Merged
merged 1 commit into from Aug 21, 2023

Conversation

davidgilkaufman
Copy link
Contributor

@davidgilkaufman davidgilkaufman commented Jun 15, 2023

WIP, but mostly done. Still TODO:

  • make rest machining work with saving (currently it only works using operations that have generated paths since opening the file)
  • disable setting debug log level in Path/Op/Area.py
  • change UI for enable rest machining instead of multiple modes?
  • squash commits
  • Bug: path dressups mask the clearedArea property -- look into how those are implemented, and loop through sub operations

Forum thread: https://forum.freecad.org/viewtopic.php?t=78773
Issue: #9756

Thank you for creating a pull request to contribute to FreeCAD! Place an "X" in between the brackets below to "check off" to confirm that you have satisfied the requirement, or ask for help in the FreeCAD forum if there is something you don't understand.

  • Your Pull Request meets the requirements outlined in section 5 of CONTRIBUTING.md for a Valid PR

Please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 1.0 Changelog Forum Thread.


@github-actions github-actions bot added the WB CAM Related to the CAM/Path Workbench label Jun 15, 2023
@freecadci
Copy link

pipeline status for feature branch PR_9782. Pipeline 903682370 was triggered at 2f826a0. All CI branches and pipelines.

@luzpaz luzpaz linked an issue Jun 24, 2023 that may be closed by this pull request
2 tasks
@davidgilkaufman davidgilkaufman marked this pull request as ready for review June 26, 2023 21:29
@davidgilkaufman davidgilkaufman marked this pull request as draft June 26, 2023 21:29
@davidgilkaufman davidgilkaufman force-pushed the restMachining branch 2 times, most recently from cb2e8a4 to 092c2d8 Compare July 20, 2023 15:48
@davidgilkaufman davidgilkaufman marked this pull request as ready for review July 20, 2023 15:48
@davidgilkaufman davidgilkaufman changed the title WIP Rest Machining Rest Machining for Path and Path3D Operations Jul 20, 2023
@luzpaz
Copy link
Contributor

luzpaz commented Jul 20, 2023

Do you mind using git commit --amend and prefixing Path: to both commits titles ?

@sliptonic sliptonic self-assigned this Jul 21, 2023
@sliptonic sliptonic added this to the 1.0 milestone Jul 21, 2023
@sliptonic sliptonic merged commit 9cc7a5a into FreeCAD:master Aug 21, 2023
6 checks passed
@luzpaz
Copy link
Contributor

luzpaz commented Aug 21, 2023

Congrats @davidgilkaufman on your first PR in FreeCAD!

@davidgilkaufman davidgilkaufman deleted the restMachining branch August 22, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB CAM Related to the CAM/Path Workbench
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Problem] Path workbench lacks 'rest' capability
4 participants