Sketcher: fix CircleToCircle distance constraint with external #9822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create c2c distance constraint with one external geometry raised a malformed constraint error + clang format catch by precommit hook
|
@luzpaz Can this be marked to be merged for 0.21? |
|
@abdullahtahiriyo if you're available, do you mind reviewing? |
|
@luzpaz I think @0penBrain is competent to review and maybe more available than adbullah. The fix resides in 2 lines already used in the point to point distance constraint just above. And checkGeoId() comment says |
|
Thank you @0penBrain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create c2c distance constraint with one external geometry raised a malformed constraint error
https://forum.freecad.org/viewtopic.php?p=688538#p688538
The precommit hook also clang-formats some lines…
Thank you for creating a pull request to contribute to FreeCAD! Place an "X" in between the brackets below to "check off" to confirm that you have satisfied the requirement, or ask for help in the FreeCAD forum if there is something you don't understand.
Please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 1.0 Changelog Forum Thread.