Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass #31

Open
wants to merge 5 commits into
base: translate
Choose a base branch
from
Open

Conversation

biglemontree
Copy link

@biglemontree biglemontree commented Jul 28, 2018

翻译章节
《前端库和框架》

变更文件
sass.json

翻译进度
5/9

@huluoyang
Copy link
Contributor

句末缺少句号
多余的空白
更多是直译,不是意译,所以不够流畅。
以上问题,请详细阅读翻译指南后重新修订在提交。

@huluoyang huluoyang added the need update Use when a translation (?) PR has been reviewed and needs to address comments label Jul 28, 2018
@@ -6,38 +6,38 @@
"challenges": [
{
"id": "587d7dbd367417b2b2512bb4",
"title": "Store Data with Sass Variables",
"title": "使用sass变量储存数据",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sass => Sass
此外中英文应用空格分开,请查看翻译规范。

"One feature of Sass that's different than CSS is it uses variables. They are declared and set to store data, similar to JavaScript.",
"In JavaScript, variables are defined using the <code>let</code> and <code>const</code> keywords. In Sass, variables start with a <code>$</code> followed by the variable name.",
"Here are a couple examples:",
"Sass不同于CSS的一个特点是它使用变量。 类似于JavaScript,它们被声明并设置为存储数据",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是直译,所以显得生硬,不流畅。
句末应添加句号。

],
"tests": [
{
"text": "Your code should re-organize the CSS rules so the <code>h1</code> and <code>p</code> are nested in the <code>.blog-post</code> parent element.",
"testString": "assert(code.match(/\\.blog-post\\s*?{\\s*?h1\\s*?{\\s*?text-align:\\s*?center;\\s*?color:\\s*?blue;\\s*?}\\s*?p\\s*?{\\s*?font-size:\\s*?20px;\\s*?}\\s*?}/gi), 'Your code should re-organize the CSS rules so the <code>h1</code> and <code>p</code> are nested in the <code>.blog-post</code> parent element.');"
"text": "您的代码应重新组织CSS规则,以便 <code>h1</code> 和 <code>p</code> 嵌套在 <code>.blog-post</code> 父元素中。",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

您=>你

Copy link
Author

@biglemontree biglemontree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

欢迎review

Copy link
Contributor

@S1ngS1ng S1ngS1ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@biglemontree 这表示有 syntax error(语法错误)。这些是 JSON 文件,每行结尾不能用中文逗号的

@biglemontree
Copy link
Author

完成第5小节, 欢迎review

Copy link
Contributor

@S1ngS1ng S1ngS1ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你前面的 testString 字段都错了。删了冒号。记得改一下

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need update Use when a translation (?) PR has been reviewed and needs to address comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants