Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that Founding Father dialog is not too small #128

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SJOS
Copy link

@SJOS SJOS commented Oct 10, 2022

Ensure that Founding Father dialog is not too small, regardless of which language is used.
This is a fix for https://sourceforge.net/p/freecol/bugs/3291/

The cause of the problem is that with the current layout, the width of the dialog is controlled by the width of the title headline ("Nominate founding father"). If using another language where the title contains fewer letters, the panel containing the description of each founding father becomes more narrow, since the text panels will state that they prefer a very narrow layout. In my experiments, it was the tabs above the panels that determined the size of the panel.
And then the text instead is rendered with more rows, making the panel using much more vertical space than the dialog window allows for, making the "Ok" button end up outside of the visible window.

One could make the dialog allow for larger height of the dialog, or add vertical scroll bars if the panel is too high. But adding code that ensure that the dialog is never too narrow, makes the dialog look nicer, at least in the languages that I tried.

Not so found of adding a constant width number, but perhaps it is a good enough solution?

@wintertime wintertime added the bug label Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants