Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.2 to the CI build process / tests. #56

Merged
merged 3 commits into from Jan 21, 2023

Conversation

ChadSikorra
Copy link
Contributor

Just adding PHP 8.2 to the build / testing to verify functionality.

…ld like to use a docker image for this instead at some point.
@codecov
Copy link

codecov bot commented Jan 21, 2023

Codecov Report

Merging #56 (f54f67c) into master (98cf7ab) will decrease coverage by 2.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #56      +/-   ##
============================================
- Coverage     87.99%   85.88%   -2.11%     
- Complexity     1828     1830       +2     
============================================
  Files           128      128              
  Lines          4255     4675     +420     
============================================
+ Hits           3744     4015     +271     
- Misses          511      660     +149     
Impacted Files Coverage Δ
.../Ldap/Protocol/Factory/ExtendedResponseFactory.php 39.28% <0.00%> (-34.05%) ⬇️
...rc/FreeDSx/Ldap/Protocol/Factory/FilterFactory.php 54.54% <0.00%> (-16.05%) ⬇️
...ol/ServerProtocolHandler/ServerAnonBindHandler.php 66.66% <0.00%> (-13.34%) ⬇️
...otocol/ServerProtocolHandler/ServerSearchTrait.php 73.07% <0.00%> (-12.64%) ⬇️
src/FreeDSx/Ldap/Protocol/Queue/ServerQueue.php 69.23% <0.00%> (-12.59%) ⬇️
...eDSx/Ldap/Server/RequestHandler/HandlerFactory.php 60.75% <0.00%> (-12.32%) ⬇️
src/FreeDSx/Ldap/Search/RangeRetrieval.php 77.61% <0.00%> (-7.64%) ⬇️
src/FreeDSx/Ldap/LdapServer.php 72.41% <0.00%> (-6.76%) ⬇️
src/FreeDSx/Ldap/Protocol/Queue/ClientQueue.php 85.71% <0.00%> (-6.60%) ⬇️
...otocol/ServerProtocolHandler/ServerBindHandler.php 81.81% <0.00%> (-5.69%) ⬇️
... and 51 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChadSikorra
Copy link
Contributor Author

Quite odd that the unix socket test for the LdapServer is consistently not working in PHP 8.2. However, I see no changes in the PHP 8.2 release notes that are obviously related.

@ChadSikorra
Copy link
Contributor Author

After further investigation, what changed here is that checking if a UNIX socket is still connected is no longer reliable with the method:

feof($socket_resource);

However, I cannot find this behavior change documented in any release notes. Perhaps this change was accidental in PHP 8.2.

… / ldap libraries to exist side by side easier.
@ChadSikorra ChadSikorra marked this pull request as ready for review January 21, 2023 21:19
@ChadSikorra
Copy link
Contributor Author

I've worked around the change of feof() in the freedsx/socket library and bumped the dependencies here. So this should be good now. This reminded me that I need to bump the dependencies in the freedsx/snmp library as well.

@ChadSikorra ChadSikorra merged commit 51935ed into FreeDSx:master Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant