New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP 8.2 to the CI build process / tests. #56
Conversation
…ld like to use a docker image for this instead at some point.
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
============================================
- Coverage 87.99% 85.88% -2.11%
- Complexity 1828 1830 +2
============================================
Files 128 128
Lines 4255 4675 +420
============================================
+ Hits 3744 4015 +271
- Misses 511 660 +149
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Quite odd that the unix socket test for the LdapServer is consistently not working in PHP 8.2. However, I see no changes in the PHP 8.2 release notes that are obviously related. |
After further investigation, what changed here is that checking if a UNIX socket is still connected is no longer reliable with the method: feof($socket_resource); However, I cannot find this behavior change documented in any release notes. Perhaps this change was accidental in PHP 8.2. |
… / ldap libraries to exist side by side easier.
I've worked around the change of |
Just adding PHP 8.2 to the build / testing to verify functionality.