Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFViperCompat #1

Closed
PeterMeyer opened this issue Jan 15, 2013 · 10 comments
Closed

FFViperCompat #1

PeterMeyer opened this issue Jan 15, 2013 · 10 comments
Assignees
@Multifalcon
Labels
blocker bug
Milestone
Fully Migrate to ...

Comments

@PeterMeyer
Copy link
Member

Right now weather Module will not initialize correctly after FFViper was compiled
correctly. This has to do with General overrides. The Problem is known and is
not solved read.

Topics: FRead Problem, past bug in VC++ Compiler.
@ghost ghost assigned Multifalcon Jan 19, 2013
@vinnydiehl
Copy link
Member

I assigned @Multifalcon to this bug as you told me he was hunting it. The bug appears to be in this method. There are a bunch of fscanf() calls and the function seems to have been overridden somewhere else in the code.

The problem here is that fscanf() simply does not work anymore. This particular freeze is caused by an infinite loops sprung by the first call of the function in the method linked above (pop some breakpoints around it to see for yourself). The fscanf() call does not affect buffer in any way, and therefore it never satisfies any of the chain of conditionals that follow and never breaks, looping that forever.

@vinnydiehl vinnydiehl mentioned this issue Jan 19, 2013
Closed
@PeterMeyer
Copy link
Member Author

Yeah lets look to the compatlib for a quick fix and hopefully we find the override.
It would be the dream if some old coder of Falcon can bring light into the dark.

@vinnydiehl
Copy link
Member

Unfortunately the person that introduced the override to the code probably hasn't touched Falcon in 8 years.

@Multifalcon
Copy link
Member

Morning, finally I have connection.

You are right about the bug, in the incialization, unfortunately, I must delay the bug fix, for reallfe issues, ASAP I will come to the FFcode.

@PlutoniumHeart
Copy link
Contributor

Hi all, I believe I have found and fixed this bug, I am wondering how I should upload this fix.

Thanks!

Plutonium

@vinnydiehl
Copy link
Member

@Multifalcon: That's not a problem, personal issues are well understood.

@PlutoniumHeart: If you think you have it fixed, take the following steps to get the patch to us for review:

  1. Fork this repository
  2. Clone your fork to your computer
  3. Create a feature branch for the fix (git checkout -b feature/file-read-fix)
  4. Apply your changes to the code
  5. Commit the changes (you can reference this issue in the commit message by mentioning FFViperCompat #1 somewhere in it)
  6. Push the commit(s) to your fork (git push origin feature/file-read-fix)
  7. Send a pull request

If you're having too much trouble with this, send me an email or a PM on the forums and you can give me the fix to apply in some other manner. Doing this through GitHub will give you proper credit, though.

@PlutoniumHeart
Copy link
Contributor

@gbchaosmaster: Hi, I should be able to do that tomorrow. But in the case that I had a problem doing this, I will let you know.

Thanks.

Plutonium

@vinnydiehl
Copy link
Member

@PlutoniumHeart: Alrighty, I look forward to seeing your changes. The sooner we can get rid of this issue, the better.

Cheers,
Vinny

@PeterMeyer
Copy link
Member Author

Good morning.
Awsome news! Good Job Plutonium ;D
@plutonium I get a Bounce message from the Mailinglist. Can you just send a fresh/new post to the List with a new subject abut this bug to it and describe what you have done? You can also send yor Patch to the Mailing list.

All the best,
Peter

@Multifalcon
Copy link
Member

Geat Job Plutonium. I work on this issue for a while and I am so happy you have found the way to fix

PlutoniumHeart added a commit to PlutoniumHeart/freefalcon-central that referenced this issue Jan 21, 2013
@PlutoniumHeart
I have found a low-level read routine overridden by the original Falc…
abc8bb7 
…on 4.0 developers.

Probably at their time this low-level read routine was not included in the VS's library,
but now it is, and the old one is not working, thus causing Issue FreeFalcon#1, I comment it out,
it seems to be working.
I also commented out a line in "TexBank.cpp" which sets the "maxCompressedSize" to 0xffffffff
causing the following new comand to fail.
The application still having problems at this point, the problem seem to be located in
"DrawParticleSys.cpp" the function "bool DrawableParticleSys::LoadParameters(void)"
I am not quite familar with DirectX stuff, so I am going to leave it to you guys at the
moment.

I have found a low-level read routine overridden by the original Falcon 4.0 developers.
Probably at their time this low-level read routine was not included in the VS's library,
but now it is, and the old one is not working, thus causing Issue FreeFalcon#1, I comment it out,
it seems to be working.
I also commented out a line in "TexBank.cpp" which sets the "maxCompressedSize" to 0xffffffff
causing the following new comand to fail.
The application still having problems at this point, the problem seem to be located in
"DrawParticleSys.cpp" the function "bool DrawableParticleSys::LoadParameters(void)"
when the while loop goes into "On("size"){}" part.
I am not quite familar with DirectX stuff, so I am going to leave it to you guys at the
moment.

Plutonium

Signed-off-by: Plutonium <zhitaoli.hust@gmail.com>
@PlutoniumHeart PlutoniumHeart mentioned this issue Jan 21, 2013
Closed
PlutoniumHeart added a commit that referenced this issue Jan 24, 2013
@PlutoniumHeart
Revisit Bug #1
ce20d73 
Signed-off-by: PlutoniumHeart <zhitaoli.hust@gmail.com>
PlutoniumHeart added a commit that referenced this issue Jan 24, 2013
@PlutoniumHeart
Merge pull request #9 from FreeFalcon/feature/revisit_bug_1
75ba6dc 
Revisit Bug #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Multifalcon Multifalcon

Labels
blocker bug
Projects
None yet
Milestone
Fully Migrate to Visual Studio 2010
Development

No branches or pull requests
4 participants
@vinnydiehl @PeterMeyer @Multifalcon @PlutoniumHeart