Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KSPSolveHermitianTranspose #257

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Fix KSPSolveHermitianTranspose #257

merged 1 commit into from
Feb 27, 2023

Conversation

cmd8
Copy link
Contributor

@cmd8 cmd8 commented Feb 26, 2023

de-conjugate x after solve

@prj- prj- merged commit a429446 into FreeFem:develop Feb 27, 2023
@prj-
Copy link
Member

prj- commented Feb 27, 2023

Thanks, good catch.

@cmd8 cmd8 deleted the develop branch February 27, 2023 06:36
@prj-
Copy link
Member

prj- commented Feb 27, 2023

In fact, this is still wrong because x may be y, so this would conjugate x twice. I'll fix this for good now 😄

@cmd8
Copy link
Contributor Author

cmd8 commented Feb 27, 2023

Ah yes, didn't realize that was possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cmd8 @prj-