Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fallback for hovering lookup on Linux systems #133

Merged
merged 6 commits into from
Jan 28, 2024

Conversation

PIPPOHSIOS
Copy link
Contributor

As per requested, I added the fallback for hovering lookup with the shift key. So it should now work on Linux, though the window must be focused. However, I think that it would be more useful if we let the user decide whether they want the fallback or not, but I didn't add that feature so we can discuss it and see what works best for you. The pynput documentation states that if the script is running under X, it should work regardless of the sudo privileges. This way, if someone it's still using X, they might benefit from using the hovering lookup feature even when the window is unfocused.

@1over137
Copy link
Contributor

Cool, but don't check for Linux, rather check for wayland directly, like this:
os.environ.get("XDG_SESSION_TYPE") == "wayland"

@1over137 1over137 merged commit fe97092 into FreeLanguageTools:master Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants