Koreader: Add support for PDF in vocabbuilder #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RasmusRendal I rebased this and fixed some issues, can you please check if it works satisfactorily in a PDF book |
Caused by bad indentation
I committed the crime of converting an epub to a pdf before sending it to my kindle, and importing vocab worked perfectly. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found myself reading a PDF file recently, and I noticed VocabSieve wasn't importing the vocabulary from it. This PR fixes that, adding PDF to the list of supported filetypes.
EDIT: I see that this closes #75. I hadn't looked at that issue before opening this PR. For the concrete book I wanted to import data from, I did get the issue with a lack of spaces around the highlighted word. Additionally, I sort of had to ninja-edit the language field of the metadata in koreader while importing with vocabsieve.