added is_connected() method & PEP-8 asyncua/client/client.py #157
Conversation
| """ | ||
| Get OPC-UA client connection status. | ||
| """ | ||
| return self.uaclient.protocol.state == UASocketProtocol.OPEN |
There was a problem hiding this comment.
this might work... but does it always work? I man can't we get errors like "protocol has not attrtbute called state",etc...
There was a problem hiding this comment.
I also tried this in my own local implementation of is_connected and had trouble getting it to be robust. For example, if I disconnected network, the connection_lost callback didn't necessarily get called immediately, and the state still remained OPEN. I settled on querying the status node of the server as it seemed to be the most reliable method, but would be interested in trying to get this method to be robust.
There was a problem hiding this comment.
Also from what I remember looking at how prosys and unified automation clients work. They seem to be polling at quite high frequency. Reading the server node once a second or similar. So this seems to be the common way to do it
There was a problem hiding this comment.
What if we call get_namespaces()? I know that it is not the cleanest way to do it but it is an option
There was a problem hiding this comment.
Why not reading the server state node? If this is what all others do.. Then you can also check what is the state of server
Close #155
Changes: