User manager and permission ruleset fix #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 4, 2020 16:20
…rs Endpoinds (also with the one with SecurityPolicy#None)
…of InternalSession to provide an encrypted password to the user-defined UserManager
|
before we can consider to merge that work you need to fix the tests. obvisouly these changes break everything so something is wrong with the patch |
|
@oroulet I added a check to password which is not provided in many tests, now all tests pass correctly. |
AndreasHeine
pushed a commit
that referenced
this pull request
Feb 5, 2021
* User-defined PermissionRuleset is now propagated to all InternalServers Endpoinds (also with the one with SecurityPolicy#None) * Fixed check_user_token method of InternalServer and activate_session of InternalSession to provide an encrypted password to the user-defined UserManager * Fixed bug in InternalServer when password is not provided Co-authored-by: Marco Panato <marco.panato_01@univr.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed two bugs in UserManager and PermissionRuleSet handling: