Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update split of NodeID from string #1152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Musiame
Copy link

@Musiame Musiame commented Oct 21, 2020

Split at the first ";" only, to handle the case where ";" is in the string identifier like in "ns=1;s=V40;0;1"

Split at the first ";" only, to handle the case where ";" is in the string identifier like in `"ns=1;s=V40;0;1"`
@oroulet
Copy link
Member

oroulet commented Nov 18, 2020

that mere request breaks tests. you need to fix tests if you want it merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants