Fix hang of calendar/fwconsole process #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long-windedly discussed on FreePBX forum the last updates (16.0.23 and up) caused hanging of the fwconsole process and the inability to view the calendar inside the admin UI. This was in particular true only for a specific type of events that contains the following (omitted non relevant values):
The UNTIL rule was causing the IcalParser library to fail and return an error that was not correctly handled by the code. Now a check is added for the return value and also to be sure that the returned value is greater than the start time of the event.
Inside the same PR I removed a goto statement in Base.php and fixed the return value of
fastHandler()
when no cache is available.