Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc_avpair_tostr() crashes on bad PW_TYPE_DATE data #85

Closed
jjberry314 opened this issue Sep 14, 2018 · 1 comment
Closed

rc_avpair_tostr() crashes on bad PW_TYPE_DATE data #85

jjberry314 opened this issue Sep 14, 2018 · 1 comment

Comments

@jjberry314
Copy link

If bad PW_TYPE_DATE data is received, a call to gmtime() will result in a NULL pointer. This is then passed to strftime() which then causes a crash.

I have submitted a pull request which guards against this.


Program received signal SIGSEGV, Segmentation fault.
__strftime_internal (s=s@entry=0x7ffeefb01610 "", maxsize=maxsize@entry=256, format=format@entry=0xa831bf "%m/%d/%y %H:%M:%S", tp=0x0, tzset_called=tzset_called@entry=0x7ffeefb01510,
loc=0x7f1d33b01060 <_nl_global_locale>) at strftime_l.c:565
565 strftime_l.c: No such file or directory.
(gdb) where
#0 __strftime_internal (s=s@entry=0x7ffeefb01610 "", maxsize=maxsize@entry=256, format=format@entry=0xa831bf "%m/%d/%y %H:%M:%S", tp=0x0,
tzset_called=tzset_called@entry=0x7ffeefb01510, loc=0x7f1d33b01060 <_nl_global_locale>) at strftime_l.c:565
#1 0x00007f1d337fbe83 in __GI___strftime_l (s=s@entry=0x7ffeefb01610 "", maxsize=maxsize@entry=256, format=format@entry=0xa831bf "%m/%d/%y %H:%M:%S", tp=,
loc=) at strftime_l.c:485
#2 0x00007f1d337fa040 in __GI_strftime (s=s@entry=0x7ffeefb01610 "", maxsize=maxsize@entry=256, format=format@entry=0xa831bf "%m/%d/%y %H:%M:%S", tp=) at strftime.c:25
#3 0x0000000000a0b72f in rc_avpair_tostr (rh=rh@entry=0x2df6750, pair=pair@entry=0x2e05680, name=name@entry=0x7ffeefb015e0 "Event-Timestamp", ln=ln@entry=33,
value=value@entry=0x7ffeefb01610 "", lv=lv@entry=256) at avpair.c:807
#4 0x0000000000a0b919 in rc_avpair_log (rh=0x2df6750, pair=,
buf=0x7ffeefb01800 "User-Name", ' ' <repeats 24 times>, "= 'AH-149-44/xt-0756'\nPassword", ' ' <repeats 25 times>, "= '5245'\nNAS-Port-Id", ' ' <repeats 22 times>, "= '2'\nAcct-Session-Id", ' ' <repeats 18 times>, "= '78a1a83e-a0a6-4c9d-b25b-f283"..., buf_len=32768) at avpair.c:838

@jjberry314
Copy link
Author

(Patch has been accepted and merged to trunk)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant