correction of counter usage for retries, fix to minor memory leak #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 23, 2011 21:51
Submitted by Lewis Adam-VNQM87 <VNQM87 a t motorola.com> on Tue, 18 May 2010 20:10:37 +0100
patch to fix the following problem:
Looking at the retry handling in rc_send_server() in sendserver.c, it
appears that "retries" actually means "tries".
if (++retries >= retry_max) {... }
After the first time out, retries is pre-incremented to 1 thus being greater than or equal
to 0 or 1 (so setting retry_max to 0 or 1 has the same effect).
From: Alex Massover <alex a t jajah.com> Date: Sun, 21 Mar 2010 13:23:05 +0200 If secret string is defined in radiusclient.conf like following: acctserver localhost:1646:mysecret (and not in 'servers' file - which btw is better way because 'servers' file is rereaded for every request), it leaks, because +serv->secret is never freed.
alandekok
added a commit
that referenced
this pull request
Jul 25, 2011
correction of counter usage for retries, fix to minor memory leak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are two of the patches submitted to you and forwarded to me for review. They look straightforward. I do not see any code that could cause dereferencing of a null pointer in the memory-leak fix, and the counter usage correction does restore what the comment says was the intended action when retry_max==0.