Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auto-generated files from git #18

Closed
wants to merge 2 commits into from
Closed

Conversation

nmav
Copy link
Contributor

@nmav nmav commented Dec 9, 2014

This patch set removes all auto-generated files (with autoreconf) from git.

@alandekok
Copy link
Member

We can't commit this change. The purpose of git is to track changes to the build system. This includes auto-generated files. Otherwise, we would have no way of tracking (and reproducing) releases.

On a personal note, I have a frothing hatred for projects which tell you to download the source, run "autoreconf", then "configure", then "make". They fundamentally miss the point about "configure".

The "configure" scripts are supposed to check if you have the correct libraries, headers, and build tools required to "make" the project. If you need another build tool to create the configure scripts, then configure becomes almost useless.

One major problem with forcing people to use "autoreconf" is that different versions of it are incompatible with each other. So if you use version X, and I download your software, and use it with version Y, I can't even create a configure script. As a developer, you've just given me a big "fuck you, I don't want you using my software".

I have undying hatred for projects like that.

@alandekok alandekok closed this Dec 9, 2014
@nmav
Copy link
Contributor Author

nmav commented Dec 9, 2014

I don't have strong opinion about that, but development is pretty hard on freeradius-client as git status prints a ton of files, and git commit will include unrelated changes.

These files are mostly needed on releases, and as far as I understand freeradius-client doesn't do that anyway :)

@arr2036
Copy link
Member

arr2036 commented Dec 9, 2014

.gitignore?

@alandekok
Copy link
Member

The only reason git status prints a ton of files is if you're running autoreconf. Don't do that.

When I run git status, it prints nothing. Even after a configure and make. So the .gitignore file is correct.

And git commit includes unrelated changes only when you do git commit ., which is generally not recommended. Instead, you should commit the changes you made, not just randomly everything in the source tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants