Fix size of attribute type and vendor IDs #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests fail, so those have to be fixed before the patch is added. |
|
Sure, as soon as somebody tells me how the tests are built and executed I can have a look into it. |
|
Oh I see now. The problem is, that the example dictionary file contains non-protocol attributes that "are used internally by the server". As this is the client side I will just remove them from the dictionary. |
This commit fixes the representation of attribute type and vendor ID.
According to RFC 2865 attribute type is one octet and vendor ID is
three octets. So now, the combination of both is calculated as follows:
combined = (vendor_id << 8) | attribute_type
This commit resolves #72
Signed-off-by: Marcel Patzlaff <m.patzlaff@pilz.de>
Signed-off-by: Marcel Patzlaff <m.patzlaff@pilz.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the representation of attribute type and vendor ID.
According to RFC 2865 attribute type is one octet and vendor ID is
three octets. So now, the combination of both is calculated as follows:
This commit resolves #72