Move checks for virtual_server to listen_parse()

Which is better than scattering them through the code.

src/main/listen.c

@@ -2748,6 +2748,7 @@ static rad_listen_t *listen_parse(CONF_SECTION *cs, char const *server)
 	CONF_PAIR	*cp;
 	char const	*value;
 	lt_dlhandle	handle;
+	CONF_SECTION	*server_cs;
 	char		buffer[32];
 
 	cp = cf_pair_find(cs, "type");
@@ -2862,6 +2863,15 @@ static rad_listen_t *listen_parse(CONF_SECTION *cs, char const *server)
 		return NULL;
 	}
 
+
+	server_cs = cf_section_sub_find_name2(main_config.config, "server",
+					      this->server);
+	if (!server_cs) {
+		cf_log_err_cs(cs, "No such server \"%s\"", this->server);
+		listen_free(&this);
+		return NULL;
+	}
+
 	cf_log_info(cs, "}");
 
 	return this;

src/main/modules.c

@@ -1547,7 +1547,6 @@ int modules_init(CONF_SECTION *config)
 {
 	CONF_ITEM	*ci, *next;
 	CONF_SECTION	*cs, *modules;
-	rad_listen_t	*listener;
 
 	/*
 	 *	Set up the internal module struct.
@@ -1746,29 +1745,6 @@ int modules_init(CONF_SECTION *config)
 	}
 	cf_log_info(cs, " } # modules");
 
-	/*
-	 *	Loop over the listeners, figuring out which sections
-	 *	to load.
-	 */
-	for (listener = main_config.listen;
-	     listener != NULL;
-	     listener = listener->next) {
-		char buffer[256];
-
-#ifdef WITH_PROXY
-		if (listener->type == RAD_LISTEN_PROXY) continue;
-#endif
-
-		cs = cf_section_sub_find_name2(config,
-					       "server", listener->server);
-		if (!cs && (listener->server != NULL)) {
-			listener->print(listener, buffer, sizeof(buffer));
-
-			ERROR("No server has been defined for %s", buffer);
-			return -1;
-		}
-	}
-
 	if (virtual_servers_load(config) < 0) return -1;
 
 	return 0;