CID #1206501 - Check dup was ok in fr_log_talloc_report

FreeRADIUS · Apr 26, 2014 · 2543ec8 · 2543ec8
1 parent ec482c3
commit 2543ec8
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/lib/debug.c b/src/lib/debug.c
@@ -468,11 +468,16 @@ int fr_log_talloc_report(TALLOC_CTX *ctx)
 	FILE *log;
 	char const *null_ctx = NULL;
 	int i = 0;
+	int fd;
 
-	log = fdopen(dup(fr_fault_log_fd), "w");
+	fd = dup(fr_fault_log_fd);
+	if (fd < 0) {
+		fr_strerror_printf("Couldn't write memory report, failed to dup log fd: %s", fr_syserror(errno));
+		return -1;
+	}
+	log = fdopen(fd, "w");
 	if (!log) {
 		fr_strerror_printf("Couldn't write memory report, fdopen failed: %s", fr_syserror(errno));
-
 		return -1;
 	}