set vnode_fd = -1 on close

FreeRADIUS · Feb 28, 2018 · 43b2c6b · 43b2c6b
1 parent 8d274a1
commit 43b2c6b
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/modules/proto_detail/proto_detail_file.c b/src/modules/proto_detail/proto_detail_file.c
@@ -392,9 +392,12 @@ static int work_exists(proto_detail_file_t *inst, int fd)
 
 	if (!fr_schedule_socket_add(inst->parent->sc, listen)) {
 	error:
-		if ((inst->vnode_fd >= 0) &&
-		    (fr_event_fd_delete(inst->el, inst->vnode_fd, FR_EVENT_FILTER_VNODE) < 0)) {
-			PERROR("Failed removing DELETE callback when opening work file");
+		if (inst->vnode_fd >= 0) {
+			if (fr_event_fd_delete(inst->el, inst->vnode_fd, FR_EVENT_FILTER_VNODE) < 0) {
+				PERROR("Failed removing DELETE callback when opening work file");
+			}
+			close(inst->vnode_fd);
+			inst->vnode_fd = -1;
 		}
 
 		if (opened) {