Skip to content

Commit

Permalink
Revert "add and use sanity check functions for dlists"
Browse files Browse the repository at this point in the history
This reverts commit 147307e.

nope
  • Loading branch information
alandekok committed Dec 13, 2019
1 parent 147307e commit 44b32a8
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
2 changes: 0 additions & 2 deletions src/lib/io/worker.c
Expand Up @@ -757,7 +757,6 @@ static REQUEST *fr_worker_get_request(fr_worker_t *worker, fr_time_t now)
REQUEST_VERIFY(request);
rad_assert(request->runnable_id < 0);
fr_time_tracking_resume(&request->async->tracking, now, &worker->tracking);
rad_assert(fr_dlist_entry_empty(&request->async->tracking.list.entry));
return request;
}

Expand Down Expand Up @@ -1012,7 +1011,6 @@ static void fr_worker_run_request(fr_worker_t *worker, REQUEST *request)
break;

case RLM_MODULE_YIELD:
rad_assert(fr_dlist_entry_empty(&request->async->tracking.list.entry));
fr_time_tracking_yield(&request->async->tracking, fr_time(), &worker->tracking);
return;

Expand Down
9 changes: 0 additions & 9 deletions src/lib/util/dlist.h
Expand Up @@ -393,15 +393,6 @@ static inline CC_HINT(nonnull(1)) void *fr_dlist_remove(fr_dlist_head_t *list_he
return (void *) (((uint8_t *) prev) - list_head->offset);
}

#ifndef NDEBUG
static inline bool fr_dlist_entry_empty(fr_dlist_t const *entry)
{
if (entry->prev != entry->next) return false;
if (entry->prev != entry) return false;
return true;
}
#endif

/** Check all items in the list are valid
*
* Checks item talloc headers and types to ensure they're consistent
Expand Down

0 comments on commit 44b32a8

Please sign in to comment.