Skip to content

Commit

Permalink
Use refs not expansions
Browse files Browse the repository at this point in the history
They seem to work more reliably, and it's nicer to have tests fail for the things they're actually supposed to be testing instead of randomly.
  • Loading branch information
arr2036 committed Dec 10, 2018
1 parent 52095c5 commit babc407
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/tests/keywords/3gpp
Expand Up @@ -10,8 +10,8 @@ update request {
# by an attribute.
#
update control {
&Tmp-String-0 := "%{3GPP-IMSI}"
&Tmp-String-1 := "%{request:3GPP-IMSI}"
&Tmp-String-0 := &3GPP-IMSI
&Tmp-String-1 := &request:3GPP-IMSI
}

success
4 changes: 2 additions & 2 deletions src/tests/keywords/cast-ipaddr
Expand Up @@ -8,10 +8,10 @@ update {
}

update request {
&Tmp-String-0[0] := "%{request:NAS-IP-Address}"
&Tmp-String-0[0] := &NAS-IP-Address
}

if (<ipaddr>&Tmp-Integer-0[0] != NAS-IP-Address) {
if (<ipaddr>&Tmp-Integer-0[0] != &NAS-IP-Address) {
test_fail
}

Expand Down

0 comments on commit babc407

Please sign in to comment.