Quiet clang scan

FreeRADIUS · Mar 2, 2017 · cdcd8b3 · cdcd8b3
1 parent 3dcae91
commit cdcd8b3
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/src/main/dl.c b/src/main/dl.c
@@ -101,23 +101,27 @@ static int dl_module_sym_init_cmp(void const *one, void const *two)
 	dl_module_sym_init_t const *a = one;
 	dl_module_sym_init_t const *b = two;
 
+	rad_assert(a && b);
+
 	if (a->symbol && !b->symbol) return +1;
 	if (!b->symbol && a->symbol) return -1;
-	if (!a->symbol && !b->symbol) return 0;
+	if (a->symbol && b->symbol) return strcmp(a->symbol, b->symbol);
 
-	return strcmp(a->symbol, b->symbol);
+	return 0;
 }
 
 static int dl_module_sym_free_cmp(void const *one, void const *two)
 {
 	dl_module_sym_free_t const *a = one;
 	dl_module_sym_free_t const *b = two;
 
+	rad_assert(a && b);
+
 	if (a->symbol && !b->symbol) return +1;
 	if (!b->symbol && a->symbol) return -1;
-	if (!a->symbol && !b->symbol) return 0;
+	if (a->symbol && b->symbol) strcmp(a->symbol, b->symbol);
 
-	return strcmp(a->symbol, b->symbol);
+	return 0;
 }
 
 static int dl_module_sym_cmp(void const *one, void const *two)