outfp may be MULL

FreeRADIUS · Apr 19, 2014 · d0364cf · d0364cf
1 parent 5be020a
commit d0364cf
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/modules/rlm_detail/rlm_detail.c b/src/modules/rlm_detail/rlm_detail.c
@@ -408,7 +408,7 @@ static rlm_rcode_t detail_do(void *instance, REQUEST *request, RADIUS_PACKET *pa
 	if ((outfp = fdopen(outfd, "a")) == NULL) {
 		RERROR("Couldn't open file %s: %s", buffer, fr_syserror(errno));
 	fail:
-		fclose(outfp);
+		if (outfp) fclose(outfp);
 		fr_logfile_unlock(inst->lf, outfd);
 		return RLM_MODULE_FAIL;
 	}