Set request->username and request->password fields to NULL if the req…

…uest list is deleted
FreeRADIUS · Feb 24, 2014 · db4365c · db4365c
1 parent 0aa5b3d
commit db4365c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/main/valuepair.c b/src/main/valuepair.c
@@ -1151,6 +1151,12 @@ int radius_map2vp(VALUE_PAIR **out, REQUEST *request, value_pair_map_t const *ma
 
 			pairfree(from);
 
+			/* @fixme hacky! */
+			if (map->dst->list == PAIR_LIST_REQUEST) {
+				context->username = NULL;
+				context->password = NULL;
+			}
+
 			return 0;
 		}
 

diff --git a/src/tests/keywords/update-delete b/src/tests/keywords/update-delete
@@ -33,3 +33,8 @@ if ((Tmp-String-0 && (Tmp-String-0 == 'foobarbaz')) || \
 		reply:Filter-Id := 'fail'
 	}
 }
+
+# This will of been removed too
+update request {
+	User-Password := 'hello'
+}