Skip to content

Commit

Permalink
We *MUST NOT* free the data pointer explicitly. Anything that allocat…
Browse files Browse the repository at this point in the history
…es and expects it to be freed MUST allocate from the context of the packet.

This caused abort() in radsniff
  • Loading branch information
arr2036 committed Jul 23, 2013
1 parent 16fbccf commit f1be0ba
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/lib/radius.c
Expand Up @@ -4581,8 +4581,6 @@ void rad_free(RADIUS_PACKET **radius_packet_ptr)
if (!radius_packet_ptr || !*radius_packet_ptr) return;
radius_packet = *radius_packet_ptr;

talloc_free(radius_packet->data); /* not really necessary... */

pairfree(&radius_packet->vps);

talloc_free(radius_packet);
Expand Down

0 comments on commit f1be0ba

Please sign in to comment.