Incorrect type for MIP6-Home-Link-Prefix

[herwinw]

Issue type

• Defect - Non compliance with a standards document, or incorrect API usage.

Defect/Feature description

The dictionaries list MIP6-Home-Link-Prefix as type ipv6prefix, just as e.g. Framed-IPv6-Prefix. However, there is a subtle difference in the RFCs here.

Framed-IPv6-Prefix has a payload of 1 reserved bytes (always 0x00), 1 byte for prefix-length (range 0x00-0x7f) and 0-16 bytes for the address (bytes outside the address mask may be omitted).
MIP6-Home-Link-Prefix does not have the reserved byte, and always uses 16 bytes for the address.

[arr2036]

Wow. That's just garbage.

[herwinw]

Well, wireshark uses the ipv6prefix-format for this attribute as well, so I guess most of the world has got it wrong. Not really surprising

[alandekok]

Wireshark copies the FreeRADIUS dictionaries. :(

[guyharris]

Wireshark copies the FreeRADIUS dictionaries.

$ wc -l radius/dictionary.* | tail -1
   23669 total

The alternative would be worse.

As noted above, Wireshark's picked up the change, and it's been backported to the Wireshark 2.6, 2.4, and 2.2 branches, so the next 2.6.x, 2.4.x, and 2.2.x releases should have the fix.

[alandekok]

On Aug 3, 2018, at 12:38 AM, Guy Harris ***@***.***> wrote: Wireshark copies the FreeRADIUS dictionaries.

Yup. My unhappy face was not about the copying, but about the propagation of the error.

$ wc -l radius/dictionary.* | tail -1 23669 total The alternative would be worse. As noted above, Wireshark's picked up the change, and it's been backported to the Wireshark 2.6, 2.4, and 2.2 branches, so the next 2.6.x, 2.4.x, and 2.2.x releases should have the fix.

Thanks. Some other projects copy the FR dictionaries, make local changes, and then never send the changes back. That behaviour should be discouraged.

[infrastation]

Besides that, RFC 5447 defines MIP6-Feature-Vector as Unsigned64, not OctetString. Both attributes from RFC 5447 have incorrect types in the registry (already reported).

[alandekok]

I've pushed a fix for MIP6-Feature-Vector

[infrastation]

Thank you!

[herwinw]

Notify to @guyharris You might want to import that change in Wireshark as well

[guyharris]

I've pushed a fix for MIP6-Feature-Vector

It doesn't appear to have shown up in https://github.com/FreeRADIUS/freeradius-server.git yet.

[herwinw]

It doesn't appear to have shown up in https://github.com/FreeRADIUS/freeradius-server.git yet.

It is available in the 3.0-branch

e4f385f

[guyharris]

I.e., the master branch doesn't have the latest version of the code or dictionaries?

So from which branch should I be picking up dictionaries? master, or a release branch?

[alandekok]

I've just pushed it to the master branch.

My $0.02 is that wireshark should be grabbing the dictionaries from the v3.0.x branch. That's stable.

The master branch is being actively developed, and we're re-working much of the architecture. Including how dictionaries are handled, parsed, and what data types are allowed.

I don't think Wireshark wants to keep updating their code to stay in sync with a moving target. So the v3.0.x branch is the best choice for now.

[guyharris]

My $0.02 is that wireshark should be grabbing the dictionaries from the v3.0.x branch. That's stable.

OK, I've picked up the dictionary.rfc5447 file from that branch.

The master branch is being actively developed, and we're re-working much of the architecture. Including how dictionaries are handled, parsed, and what data types are allowed.

So is the syntax of dictionary files changing?

[arr2036]

So is the syntax of dictionary files changing?

It's being extended. Keywords are being added to specify complex structural attributes, i.e. those containing multiple fixed fields and variable fields. Keywords are being added to allow "foreign" attributes i.e. DHCP in RADIUS. Some dictionary files will also be qualified with protocol blocks, specifying global options for the attributes, and indicating which protocol they belong to. The majority of keywords will be consistent with v3.0.x, but many files will be moved/reorganised. As of v4.0.x FreeRADIUS is not a RADIUS server, it's a multi-protocol policy server which implements RADIUS.