varchar(50) for connectinfo_start in radacct may be too short

[yangzhaofeng]

Issue type

---

• Defect - Unexpected behaviour (obvious or verified by project member).

freeradius-server/raddb/mods-config/sql/main/mysql/schema.sql

Line 33 in 26d547a

connectinfo_start varchar(50) default NULL,

50 may be too short for the increasing length of VPN client "user agents"

Defect

How to reproduce the issue

Connect to OpenConnect server with a client of a long "user agent" (like network-manager-openconnect(-gnome) with openconnect 8.10-2 on Debian bullseye, the "user agent" is OpenConnect VPN Agent =28NetworkManager=29 v8.10-2=2Bb1, longer than 50 chars).

To workaround: temporarily disable strict mode for mysql. The "user agent" will be truncated.

Output of [radiusd|freeradius] -X showing issue occurring

(1) sql:    --> INSERT INTO radacct (acctsessionid,		acctuniqueid,		username, realm,		nasipaddress,		nasportid, nasporttype,		acctstarttime,		acctupdatetime, acctstoptime,		acctsessiontime, 	acctauthentic, connectinfo_start,	connectinfo_stop, 	acctinputoctets, acctoutputoctets,	calledstationid, 	callingstationid, acctterminatecause,	servicetype,		framedprotocol, framedipaddress) VALUES ('YuUSumym/Ulmo8zK54cmYpBIhzc=3D', 'e642f677fcd8f3a2f6737ad49840f384', 'Steven', '', '<hidden>', '', '', FROM_UNIXTIME(1615446300), FROM_UNIXTIME(1615446300), NULL, '0', 'RADIUS', 'OpenConnect VPN Agent =28NetworkManager=29 v8.10-2=2Bb1', '', '0', '0', '', '<hidden>', '', 'Framed-User', 'PPP', '')
(1) sql: Executing query: INSERT INTO radacct (acctsessionid,		acctuniqueid,		username, realm,	nasipaddress,		nasportid, nasporttype,		acctstarttime,		acctupdatetime, acctstoptime,		acctsessiontime, 	acctauthentic, connectinfo_start,	connectinfo_stop, 	acctinputoctets, acctoutputoctets,	calledstationid, 	callingstationid, acctterminatecause,	servicetype,		framedprotocol, framedipaddress) VALUES ('YuUSumym/Ulmo8zK54cmYpBIhzc=3D', 'e642f677fcd8f3a2f6737ad49840f384', 'Steven', '', '<hidden>', '', '', FROM_UNIXTIME(1615446300), FROM_UNIXTIME(1615446300), NULL, '0', 'RADIUS', 'OpenConnect VPN Agent =28NetworkManager=29 v8.10-2=2Bb1', '', '0', '0', '', '<hidden>', '', 'Framed-User', 'PPP', '')
(1) sql: ERROR: rlm_sql_mysql: ERROR 1406 (Data too long for column 'connectinfo_start' at row 1): 22001
(1) sql: SQL query returned: server error
rlm_sql (sql): Released connection (4)
(1)     [sql] = fail
(1)   } # accounting = fail
(1) Not sending reply to client.
(1) Finished request
(1) Cleaning up request packet ID 168 with timestamp +8

[mcnewton]

Bumped up, should keep it going for a while longer. But people can always increase it locally if needed.