Add Jenkins continuous integration to FreeRADIUS for v3.0.x #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpereira
reviewed
Apr 19, 2019
| sh 'for file in $(grep "^Source...:" redhat/freeradius.spec | cut -d" " -f2) ; do cp redhat/$file rpmbuild/SOURCES/$file ; done' | ||
| sh 'rpmbuild --define "_topdir $(pwd)/rpmbuild" -bb redhat/freeradius.spec' | ||
| } else { | ||
| sh "make deb" |
There was a problem hiding this comment.
It could be good to include an extra check for Debian base then an error message for unknown OS.
...
if (platform.contains("centos") || platform.contains("redhat")) {
sh "yum-builddep -C --assumeyes redhat/freeradius.spec"
sh "make rpm"
else if (platform.contains("debian") || platform.contains("ubuntu") ) {
sh "make deb"
} else {
sh "echo 'Unknown OS'; exit 1;"
}
...
There was a problem hiding this comment.
That is not a bad idea. Maybe I'll do another PR with that.
| # | ||
|
|
||
| # Use LTB's openldap packages intead of the distribution version to avoid linking against NSS | ||
| RUN echo $'[ltb-project]\n\ |
There was a problem hiding this comment.
That file creation could be changed to provide that file into the filesystem and just use the command COPY
e.g:
COPY ltb-project.repo /etc/yum.repos.d/ltb-project.repo
ps: you should create that file into the same Dockerfile path.
| # | ||
|
|
||
| # Use LTB's openldap packages intead of the distribution version to avoid linking against NSS | ||
| RUN echo $'[ltb-project]\n\ |
There was a problem hiding this comment.
Can just reuse the previous idea about provide/reuse the file from the filesystem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.